Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add append_public_witness to TurboComposer #654

Closed
vlopes11 opened this issue Jan 5, 2022 · 0 comments · Fixed by #655
Closed

Add append_public_witness to TurboComposer #654

vlopes11 opened this issue Jan 5, 2022 · 0 comments · Fixed by #655
Assignees
@vlopes11
Labels
team:Core Low Level Core Development Team (Rust)

Comments

@vlopes11
Copy link
Contributor

vlopes11 commented Jan 5, 2022

Describe what you want implemented
A method to append a witness as public scalar.

Describe "Why" this is needed
We have available append_public_point for points, but we don't have such method for witnesses. These will avoid unnecessary constraints for the users.

Describe alternatives you've considered
The user might create the gates on his own, but then this is error-prone.

Additional context
It is desirable to have API consistency - the methods to append points should reflect the ones to append public inputs.
@vlopes11 vlopes11 added the team:Core Low Level Core Development Team (Rust) label Jan 5, 2022
@vlopes11 vlopes11 self-assigned this Jan 5, 2022
vlopes11 added a commit that referenced this issue Jan 5, 2022
@vlopes11
Add append_public_witness to TurboComposer
1093b75 
We have available `append_public_point` for points, but we don't have
such method for witnesses. These will avoid unnecessary constraints for
the users.

It is desirable to have API consistency - the methods to append points
should reflect the ones to append public inputs.

Resolves #654
@vlopes11 vlopes11 mentioned this issue Jan 5, 2022
Merged
vlopes11 added a commit that referenced this issue Jan 5, 2022
@vlopes11
Add append_public_witness to TurboComposer (#655)
8115c61 
We have available `append_public_point` for points, but we don't have
such method for witnesses. These will avoid unnecessary constraints for
the users.

It is desirable to have API consistency - the methods to append points
should reflect the ones to append public inputs.

Resolves #654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlopes11 vlopes11

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add append_public_witness to TurboComposer dusk-network/plonk
1 participant
@vlopes11