Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question for the mothod "coset_fft" #692

Closed
simplelins opened this issue Jun 10, 2022 · 1 comment
Closed

Question for the mothod "coset_fft" #692

simplelins opened this issue Jun 10, 2022 · 1 comment
Labels
fix:bug Something isn't working

Comments

@simplelins
Copy link

`fn coset_fft_in_place(&self, coeffs: &mut Vec) {
Self::distribute_powers(coeffs, GENERATOR);
self.fft_in_place(coeffs);
}
pub const GENERATOR: Scalar = Scalar([7, 0, 0, 0]);

`

for the 'GENERATOR', why we use this value in Montgomery form, but not a int value '7' convert to scale. I checked the libsnark that need convert a bigint(int:7) to a scale and then to use at coset_fft.

@simplelins simplelins added the fix:bug Something isn't working label Jun 10, 2022
@marta-belles
Copy link
Contributor

Hi @simplelins! Sorry for the late reply. We tried to find the piece of code you are pointing at, but we cannot find it (maybe after one year the code was already refactored). Feel free to reopen this issue if you think this issue is still applicable :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants