Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide modules and types other than prelude #782

Closed
moCello opened this issue Oct 19, 2023 · 0 comments · Fixed by #801
Closed

Hide modules and types other than prelude #782

moCello opened this issue Oct 19, 2023 · 0 comments · Fixed by #801
Assignees

Comments

@moCello
Copy link
Member

moCello commented Oct 19, 2023

Summary

Hide all modules that don't need to be exposed outside of the crate.

Detailed Description

Technically we only want to expose the types from the prelude but at the moment we expose many more modules and their types. This leads to unnecessary breaking changes when we want to change the inner workings of plonk.
It might be though that downstream we are using types that are not included in the prelude yet. In that case we should consider adding those to the prelude and nonetheless hide the rest.

@moCello moCello self-assigned this Nov 2, 2023
moCello added a commit that referenced this issue Dec 20, 2023
@moCello moCello mentioned this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant