Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Composer into a struct #802

Closed
moCello opened this issue Dec 20, 2023 · 0 comments · Fixed by #803
Closed

Change Composer into a struct #802

moCello opened this issue Dec 20, 2023 · 0 comments · Fixed by #803
Assignees
@moCello

Comments

@moCello
Copy link
Member

moCello commented Dec 20, 2023 •
edited

Summary

Currently we have the Composer trait that encodes the functionalities for composing a circuit.
Since we only ever implement this trait onto the Builder, we an morph the trait and struct into a single Composer struct. This comes with the added benefit that we can hide some of the trait functionalities from the public API that are now exposed but marked as deprecated (e.g. uninitialized, append_witness_internal, append_custom_gate_internal).
@moCello moCello self-assigned this Dec 20, 2023
@moCello moCello mentioned this issue Dec 21, 2023
Merged
moCello added a commit that referenced this issue Dec 21, 2023
@moCello
Turn Composer into a struct
08dc0f6 
And rename `Arithmetization` to `Gate`.

Resolves #802
@moCello moCello mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moCello moCello

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn Composer trait into a struct dusk-network/plonk
1 participant
@moCello