Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pippenger inclusion #120

Merged
merged 7 commits into from Mar 4, 2020
Merged

Pippenger inclusion #120

merged 7 commits into from Mar 4, 2020

Conversation

CPerezz
Copy link
Contributor

@CPerezz CPerezz commented Mar 4, 2020

Includes multiscalar_mul from our Bls12_381 fork based on Pippenger's algorithm.

@CPerezz
Add dusk Bls12_381 fork as dep
44f8422 
- Document that ´multiscalar_mul` found in `utils.rs`
will no longer be used. Instead we will use the pippenger
implementation added to the BLS fork.
@CPerezz
Refactor repo to use pippenger for multiscalar_mul
c36046f 
- `key` and `proof` now use the pippenger implementation
of the BLS fork for performing multiscalar multiplication
operations.

- Renamed the `single_base_multiscalar_mul` and added comments
to show that it is just used to compute the SRS and it's not
PLONK's responsability to make it faster. We just have it for
tests.
@CPerezz
Merge branch 'master' into pippenger_inclusion
993394b
@CPerezz CPerezz added enhancement area:circuit-performance Circuit performance-related topics labels Mar 4, 2020
@CPerezz CPerezz added this to the 2nd Iteration milestone Mar 4, 2020
@CPerezz CPerezz requested a review from kevaundray March 4, 2020 10:12
@CPerezz CPerezz self-assigned this Mar 4, 2020
@kevaundray
Copy link
Collaborator

Hey, just one thing, can you have the bls repo take an iterator instead of a slice, so you don't need to collect then do into_iter in the pippenger function?

@CPerezz
Copy link
Contributor Author

CPerezz commented Mar 4, 2020

Hey, just one thing, can you have the bls repo take an iterator instead of a slice, so you don't need to collect then do into_iter in the pippenger function?

You're right, it makes completely sense.
I'm changing it, will refactor the BLS fork and then update the code.

@kevaundray kevaundray merged commit c77aeb1 into master Mar 4, 2020
@kevaundray kevaundray deleted the pippenger_inclusion branch March 4, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

Assignees

@CPerezz CPerezz

Labels
area:circuit-performance Circuit performance-related topics
Projects
None yet
Milestone
2nd Iteration
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CPerezz @kevaundray