This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Port generic gadgets from Blindbid library to this one. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 10, 2020 11:46
Since the latest version of PLONK already includes builtin functions with dedicated custom gates in order to perform ECC operations. It doesn't make any sense to have them re-defined here since take like 10x more constraints than the ones built-in plonk.
- Use the latest version of `dusk-plonk` - Add anyhow & thiserror for error handling. - Remove the rest of no-longer-needed dependencies.
We have and will have more gadgets that might fail due to some computations that need to be performed inside. Therefore, `GadgetErrors` enum is created in order to hold all of the error variants that we might have in our gadgets execution processes.
- Refactored the API since a lot of functions were different. - Optimized the `non_zero` gadget to use less gates.
The previous tests were too large and also difficult to understand. Now the tests are much cleaner for the conditional selection gadgets for correct and incorrect cases.
Since this is a general-purpose gadget and it's not specific to the blindibd library, it is more useful to have this kind of gadgets on this repo as a "container" shared across all of our libraries. Closes #10
vlopes11
suggested changes
Aug 11, 2020
vlopes11
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a general-purpose gadget and it's not specific
to the blindibd library, it is more useful to have this kind of
gadgets on this repo as a "container" shared across all of our
libraries.
Closes #10