-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consensus: Distinguish Invalid vote from Timeout #1176
Labels
module:consensus
Issues related to consensus module
Comments
See #1183 (comment) |
herr-seppia
added a commit
that referenced
this issue
Jan 24, 2024
herr-seppia
added a commit
that referenced
this issue
Jan 24, 2024
herr-seppia
added a commit
that referenced
this issue
Jan 24, 2024
herr-seppia
added a commit
that referenced
this issue
Jan 24, 2024
herr-seppia
added a commit
that referenced
this issue
Jan 26, 2024
herr-seppia
added a commit
that referenced
this issue
Jan 26, 2024
herr-seppia
added a commit
that referenced
this issue
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently, Provisioners cast the same vote (a signature over a empty hash) for both an invalid block and a timeout event (unknown candidate).
This prevents determining if the Provisioner received an invalid candidate or simply didn't receive any candidate.
Relevant Context
This change is necessary to decide if a block is invalid (a quorum of Invalid votes is needed) and possibly implement Slashing over the misbehaving Generator.
Possible Solution
valid
field to Reduction messages.block_hash
field is empty only (valid
can be ignored)block_hash
contains the block hash (valid
can be set totrue
if the block is valid, andfalse
otherwise)Alternative solutions can be proposed
The text was updated successfully, but these errors were encountered: