Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: Distinguish Invalid vote from Timeout #1176

Closed
fed-franz opened this issue Dec 4, 2023 · 1 comment · Fixed by #1264
Closed

consensus: Distinguish Invalid vote from Timeout #1176

fed-franz opened this issue Dec 4, 2023 · 1 comment · Fixed by #1264
Assignees
Labels
module:consensus Issues related to consensus module

Comments

@fed-franz
Copy link
Contributor

Summary

Currently, Provisioners cast the same vote (a signature over a empty hash) for both an invalid block and a timeout event (unknown candidate).

This prevents determining if the Provisioner received an invalid candidate or simply didn't receive any candidate.

Relevant Context

This change is necessary to decide if a block is invalid (a quorum of Invalid votes is needed) and possibly implement Slashing over the misbehaving Generator.

Possible Solution

  • Add a valid field to Reduction messages.
  • When casting a vote:
    • if the candidate is unknown (Selection timeout-ed) the block_hash field is empty only (valid can be ignored)
    • if the candidate is known, block_hash contains the block hash (valid can be set to true if the block is valid, and false otherwise)

Alternative solutions can be proposed

@herr-seppia
Copy link
Member

See #1183 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:consensus Issues related to consensus module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants