Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explorer: fix badge width tx fees format optimizing headers #1861

Merged
merged 1 commit into from
Jun 18, 2024
Merged

explorer: fix badge width tx fees format optimizing headers #1861

merged 1 commit into from
Jun 18, 2024

Conversation

deuch13
Copy link
Contributor

@deuch13 deuch13 commented Jun 17, 2024 •
edited
Loading

Resolves #1789
Resolves #1793
Resolves #1794
Resolves #1795

@deuch13 deuch13 added the module:explorer Issues related to explorer module label Jun 17, 2024
@deuch13 deuch13 self-assigned this Jun 17, 2024
@deuch13 deuch13 marked this pull request as ready for review June 17, 2024 10:23
kieranhall
kieranhall reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@kieranhall kieranhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments because I don't see these changes in the Figma design, which is confusing as Figma should be the source of truth for design and presentation.

explorer/src/style/main.css Outdated Show resolved Hide resolved
explorer/src/lib/components/blocks-table/BlocksTable.svelte Show resolved Hide resolved
explorer/src/lib/components/blocks-table/BlocksTable.svelte Show resolved Hide resolved
explorer/src/lib/components/blocks-list/BlocksList.svelte Outdated Show resolved Hide resolved
explorer/src/lib/components/blocks-list/BlocksList.svelte Outdated Show resolved Hide resolved
@deuch13 deuch13 force-pushed the feature-1795 branch 3 times, most recently from 81cff1c to 2ee9a50 Compare June 18, 2024 12:53
@deuch13 deuch13 requested a review from kieranhall June 18, 2024 13:11
kieranhall
kieranhall approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@kieranhall kieranhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issues raised!

@deuch13 deuch13 merged commit b7a4838 into master Jun 18, 2024
8 checks passed
@deuch13 deuch13 deleted the feature-1795 branch June 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieranhall kieranhall kieranhall approved these changes

@nortonandreev nortonandreev Awaiting requested review from nortonandreev

Assignees

@deuch13 deuch13

Labels
module:explorer Issues related to explorer module
Projects
None yet
Milestone
No milestone
2 participants
@deuch13 @kieranhall