rusk: fix high gas limit TXs taking longer #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
added
type:enhancement
ureeves
force-pushed
the
high-gas-limit-605
branch
2 times, most recently
from
149c8e6
to
f1d36e9
Compare
herr-seppia
requested changes
Mar 1, 2022
ureeves
force-pushed
the
high-gas-limit-605
branch
2 times, most recently
from
363f117
to
6072e34
Compare
|
I added a test proving the behavior is as expected. I also played around with the suggested performance improvements and even though there were gains (marginal ones), I've decided against including them due to a substantial increase in code footprint. We can always discuss them in a future PR/issue. |
ureeves
force-pushed
the
high-gas-limit-605
branch
2 times, most recently
from
6264a75
to
20ef4e4
Compare
herr-seppia
approved these changes
Mar 7, 2022
| &refunds[i as usize], | ||
| &receiver, | ||
| amount, | ||
| 1_000_000_000, |
There was a problem hiding this comment.
Does this mean that is now safe to send txs even with GasLimit higher than the BlockGasLimit?
There was a problem hiding this comment.
Yes it does. As long as the gas spent is ultimately smaller or equal than the gas left in the block it will pass.
- Add `fork` method to `RuskState` allowing for copying the underlying `NetworkState` - Change `execute_state_transition` to keep transactions based on `gas_spent` instead of `gas_limit` Resolves: #605
ureeves
force-pushed
the
high-gas-limit-605
branch
from
20ef4e4
to
517c62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forkmethod toRuskStateallowing for copying the underlyingNetworkStateexecute_state_transitionto keep transactions based ongas_spentinstead ofgas_limitResolves: #605