Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Signature and Proof to be more consistent to bls12_381-sign #81

Closed
ZER0 opened this issue Mar 8, 2023 · 3 comments · Fixed by #93 or #117
Closed

Refactor Signature and Proof to be more consistent to bls12_381-sign #81

ZER0 opened this issue Mar 8, 2023 · 3 comments · Fixed by #93 or #117

Comments

@ZER0
Copy link
Contributor

ZER0 commented Mar 8, 2023

Summary

The way the two struct are defined are a bit weird:

  1. The Proof should be called DoubleSignature
  2. The PublicKeyPair shouldn't exists
  3. We should have a method / function to sign and verify similar how bls12_381-sign

Possible solution design or implementation

See the summary.

Additional context

See also #80
@HDauven
Copy link
Member

HDauven commented Oct 30, 2023 •
edited

Point 1. resolved by #89 #90.

This was referenced Nov 1, 2023
Merged
Closed
@moCello
Copy link
Member

moCello commented Nov 1, 2023

point 2 will be resolved by #95

@ureeves ureeves mentioned this issue Nov 22, 2023
Merged
@moCello moCello reopened this Dec 12, 2023
@moCello
Copy link
Member

moCello commented Dec 12, 2023

verify needs to be a method on the public key and not on the signatures

moCello added a commit that referenced this issue Dec 12, 2023
@moCello
Change verify to be a method on the public key
c48bb7c 
Resolves #81
moCello added a commit that referenced this issue Dec 12, 2023
@moCello
Change verify to be a method on the public key
11fc0a2 
Resolves #81
@moCello moCello mentioned this issue Dec 12, 2023
Merged
moCello added a commit that referenced this issue Dec 12, 2023
@moCello
Change verify to be a method on the public key
e114676 
Resolves #81
@moCello moCello mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ZER0 @HDauven @moCello