Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interactive stake-allow doesn't work #222

Closed
Daksh14 opened this issue Nov 17, 2023 · 1 comment · Fixed by #224
Closed

interactive stake-allow doesn't work #222

Daksh14 opened this issue Nov 17, 2023 · 1 comment · Fixed by #224
Assignees
@Neotamandua
Labels
fix:bug Something isn't working

Comments

@Daksh14
Copy link
Contributor

Daksh14 commented Nov 17, 2023 •
edited

When you try to stake-allow with the interactive menu, it gives the error, stake not found for the key.

Something is probably checking for the existing stake and returning there since it doesn't exit. Remove this check and the error will go away.

Tagging @Neotamandua since they handled this issue before

Works in non-interactive

cargo r -r -- -n local stake-allow --key u7bwZ53tt9s2g3sfbEqxiuXNeGBrzKNNQakAafrELah29dkKakmFf1gDk56vyYocSse7ABnsPxTDddDkMcrmf1Dgd5L3arznA1rWPHH4zsYVZdD4ctAwxMvdKbHkFCgU2Ne
@Daksh14 Daksh14 added the fix:bug Something isn't working label Nov 17, 2023
@herr-seppia
Copy link
Member

If you stake_allow from the stake_contract's owner address, it should work.
Performing a stake_allow from an address that is not owner it should result in transaction erroring.

However you're right, this is a bug since the transaction is not created at all

herr-seppia added a commit that referenced this issue Dec 1, 2023
@herr-seppia
Return default stake if no stake is found.
5a7c15f 
Revert the behaviour of fetch stake to fit the previous gRPC implementation, where a default stake information was returned if no stake was found.
This allow `wallet_core` to properly fetch the `stake.counter` needed for signature generation.

Resolves #222
@herr-seppia herr-seppia mentioned this issue Dec 1, 2023
Merged
herr-seppia added a commit that referenced this issue Dec 1, 2023
@herr-seppia
Return default stake if no stake is found.
2eefeee 
Revert the behaviour of fetch stake to fit the previous gRPC implementation, where a default stake information was returned if no stake was found.
This allow `wallet_core` to properly fetch the `stake.counter` needed for signature generation.

Resolves #222
@herr-seppia herr-seppia mentioned this issue Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neotamandua Neotamandua

Labels
fix:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stake allow dusk-network/wallet-cli
3 participants
@Daksh14 @herr-seppia @Neotamandua