Implement anyhow and thiserror
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophielouisefeith
force-pushed
the
this_anyhow_error
branch
2 times, most recently
from
243da1d
to
aa02975
Compare
HDauven
reviewed
Sep 21, 2022
sophielouisefeith
force-pushed
the
this_anyhow_error
branch
from
aa02975
to
b903876
Compare
herr-seppia
requested changes
Sep 21, 2022
sophielouisefeith
force-pushed
the
this_anyhow_error
branch
from
b903876
to
2532b66
Compare
ZER0
requested changes
Sep 22, 2022
There was a problem hiding this comment.
LGTM but few comments needs to be addressed.
Also in general I would have preferred have two PRs, one solely for the Error Handling, but it's okay for this time.
However, you need to have at least two separate commits for that.
The commit messages should looks like
Implement `anyhow` and `thiserror`
- Change error handling to use the `anyhow` crate in `bin`
- Change error handling to use the `thiserror` crate in `lib`
Resolves #87
And the other:
Improve UX on password's retrying scenarios
- Change program behavior to quit if wrong seed phrase is given [#49]
- Change program behavior to have three attempts for entering a password [#46]
Resolves #46, #49
5155526
to
51f9bd7
Compare
sophielouisefeith
changed the title
anyhow and thiserror
• Change error handling to use the `anyhow` crate in `bin` • Change error handling to use the `thiserror` crate in `lib` Resolves #87
sophielouisefeith
force-pushed
the
this_anyhow_error
branch
from
51f9bd7
to
4a2d602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
• Change error handling to use the
anyhowcrate inbin• Change error handling to use the
thiserrorcrate inlibResolves #87