Drop wasmer in favor of wasmtime for tests
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we've transitioned to `wasmtime` for the entirety of our stack, we should also use it for the tests in this crate. This commit does exactly that, doing away with the `wasmer` dependency, and replacing it with `wasmtime`. This also also helps in figuring out exactly what's wrong with our test runs, by eliminating the runtime as a factor - it errors in the same way in both `debug` and `release` modes. See-also: #105
This is done by allocating a dedicated buffer and copying the contents of the response into it.
This makes the allocator explicitly responsible for the memory allocated, preventing any clobbering.
Fix `allocate` and `free_mem`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've transitioned to
wasmtimefor the entirety of our stack, we should also use it for the tests in this crate. This commit does exactly that, doing away with thewasmerdependency, and replacing it withwasmtime.This also also helps in figuring out exactly what's wrong with our test runs, by eliminating the runtime as a factor - it errors in the same way in both
debugandreleasemodes.See-also: #105