Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fullBrowserVersion and browserVersion are swapped #26

Closed
TimVanMourik opened this issue Jun 4, 2019 · 1 comment
Closed

fullBrowserVersion and browserVersion are swapped #26

TimVanMourik opened this issue Jun 4, 2019 · 1 comment

Comments

@TimVanMourik
Copy link

react-device-detect/src/components/helpers/selectors.js

Lines 51 to 52 in 6cb3670

const getBrowserFullVersion = () => browser.major;
const getBrowserVersion = () => browser.version;

The getBrowserFullVersion should return the version, not just major. And vice versa.
niraj-patel added a commit to niraj-patel/react-device-detect that referenced this issue Jun 29, 2019
@niraj-patel
[fix]fullBrowserVersion and browserVersion are swapped duskload#26
e0d1c91
duskload added a commit that referenced this issue Jul 14, 2019
@duskload
Merge pull request #29 from niraj-patel/fix-fullbrowserversion-browse…
ef29970 
…rversion

[fix]fullBrowserVersion and browserVersion are swapped #26
@duskload
Copy link
Owner

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimVanMourik @duskload