Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExceptionHandler to properly report exceptions #15

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

gilbitron
Copy link
Contributor

Instead of throwing a custom FailedJobException, we can better replicate what happens in the Laravel queue worker by properly catching and reporting exceptions.

For example, this implementation means that any custom reporters set up in the App\Exceptions\Handler class report method will be triggered.

@dusterio
Copy link
Owner

dusterio commented Apr 7, 2017

I think you are right, it will make more sense this way

@dusterio dusterio merged commit b055919 into dusterio:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants