Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in Lumen 5.6 #66

Closed
wasiqaftab opened this issue Feb 9, 2018 · 13 comments
Closed

Issue in Lumen 5.6 #66

wasiqaftab opened this issue Feb 9, 2018 · 13 comments

Comments

@wasiqaftab
Copy link

I am getting this error

Unresolvable dependency resolving [Parameter #0 [ <required> $app ]] in class Illuminate\Support\Manager

Can you please guide me how can i fix it

@CraigReeves1230
Copy link

I'm getting the exact same error. Followed the instructions to a tee.

@dusterio
Copy link
Owner

Sorry, you are getting this error when you do what exactly?
I've just tried installing this with Lumen 5.6 and so far I don't get any errors

@CraigReeves1230
Copy link

CraigReeves1230 commented Feb 15, 2018 via email

@CraigReeves1230
Copy link

If you are unable to reproduce the error, I can post up here PHP files.

@CraigReeves1230
Copy link

I have not yet tried it in Lumen 5.5.

@dusterio
Copy link
Owner

There seems to be a bug in Laravel Passport that causes this, but I found a workaround, try putting this in any SP of yours:

$this->app->singleton(\Illuminate\Hashing\HashManager::class, function ($app) {
    return new \Illuminate\Hashing\HashManager($app);
});

@CraigReeves1230
Copy link

CraigReeves1230 commented Feb 15, 2018 via email

@dusterio
Copy link
Owner

Already did :))) It took me a while to upgrade to PHP 7.1 to test this :)

@Patskimoto
Copy link

Patskimoto commented Feb 19, 2018

Not sure if this is a bad solution or a solution that wouldn't even work as I haven't migrated to 5.6 yet but instead of requiring users to put that code snippet in manually can that registered singleton go in PassportServiceProvider in the Dusterio\LumenPassport namespace?

@dusterio
Copy link
Owner

@Patskimoto you are right, I've just done that

@ThamanVelasquezBice
Copy link

This is unrelated to me, but just for the sake of cleaning up issues, could this issue be closed now? Or does it require a package update?

@wolm
Copy link

wolm commented Sep 11, 2018

@dusterio The snippet added in the PassportServiceProvider explicitly checks for version 5.6. The issue is still there in 5.7 :)

@dusterio
Copy link
Owner

@wolm sure, I modified the regex just now :) before 5.7 was released, I couldn't predict what's going to be needed hehe :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants