Use a constant for buffer lengths

Scary magic numbers
dustin · Dec 20, 2014 · 8588c81 · 8588c81
1 parent ec6b7f6
commit 8588c81
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/DS2406.cpp b/DS2406.cpp
@@ -8,7 +8,7 @@ OneWireSwitch::OneWireSwitch(OneWire *b, uint8_t *addr) {
 }
 
 bool OneWireSwitch::getSwitchState(int port) {
-    uint8_t status[10];
+    uint8_t status[DS2406_STATE_BUF_LEN];
     readStatus(status);
     return (status[7] & port) == 0;
 }
@@ -37,9 +37,8 @@ void OneWireSwitch::readStatus(uint8_t *buffer) {
     bus->write(0, 1);
     bus->write(0, 1);
 
-    for(int i = 0; i<10; i++) {
+    for(int i = 0; i<DS2406_STATE_BUF_LEN; i++) {
         buffer[i] = bus->read();
     }
     bus->reset();
 }
-
diff --git a/DS2406.h b/DS2406.h
@@ -10,6 +10,8 @@
 #define PIO_A 0x20
 #define PIO_B 0x40
 
+#define DS2406_STATE_BUF_LEN 10
+
 // Represents a single 1wire switch on an MLan.
 class OneWireSwitch {
 

diff --git a/examples/Hello/Hello.pde b/examples/Hello/Hello.pde
@@ -24,5 +24,3 @@ void loop(void)
 
     delay(1000);
 }
-
-
diff --git a/examples/SearchAndBlink/SearchAndBlink.pde b/examples/SearchAndBlink/SearchAndBlink.pde
@@ -97,5 +97,3 @@ void loop(void)
     }
     delay(1000);
 }
-
-