Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SPY-120: Adding support for SLF4J logging.
This changeset adds support for SLF4J logging. The Logger API has been modified to contain only very small backwards breaking changes, it only adds TRACE support to the interface. People not implementing the Interface directly but just implementing the AbstractLogger only need to add the new isTraceEnabled() method and inside the log() method also check for the TRACE level. As SLF4J implies, this changeset does not ship with an actual SLF4J implementation but lets you choose it at runtime with just adding the impl to the classpath. Change-Id: I178ef8c8dd7417a33d0e3914a644632b98c4a265 Reviewed-on: http://review.couchbase.org/26149 Reviewed-by: Matt Ingenthron <matt@couchbase.com> Reviewed-by: Michael Nitschinger <michael.nitschinger@couchbase.com> Tested-by: Michael Nitschinger <michael.nitschinger@couchbase.com>
- Loading branch information
Showing
10 changed files
with
255 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
src/main/java/net/spy/memcached/compat/log/SLF4JLogger.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /** | ||
| * Copyright (C) 2009-2013 Couchbase, Inc. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
| * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALING | ||
| * IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| package net.spy.memcached.compat.log; | ||
|
|
||
| /** | ||
| * Logging Implementation using the <a href="http://www.slf4j.org/">SLF4J</a> | ||
| * logging facade. | ||
| * | ||
| * <p>Note that by design, the SLF4J facade does not ship with an actual | ||
| * implementation so that it can be chosen during runtime. If you fail to | ||
| * provide a logging implementation during runtime, no log messages will | ||
| * be logged. See the <a href="http://www.slf4j.org/manual.html">SLF4J | ||
| * Manual</a> for more information on how to do this.</p> | ||
| * | ||
| * <p>Since SLF4J does not support a FATAL log level, errors logged at that | ||
| * level get promoted down to ERROR, since this is the highest level | ||
| * available.</p> | ||
| */ | ||
| public class SLF4JLogger extends AbstractLogger { | ||
|
|
||
| private final org.slf4j.Logger logger; | ||
|
|
||
| /** | ||
| * Get an instance of the SLF4JLogger. | ||
| */ | ||
| public SLF4JLogger(String name) { | ||
| super(name); | ||
| logger = org.slf4j.LoggerFactory.getLogger(name); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isTraceEnabled() { | ||
| return logger.isTraceEnabled(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isDebugEnabled() { | ||
| return logger.isDebugEnabled(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isInfoEnabled() { | ||
| return logger.isInfoEnabled(); | ||
| } | ||
|
|
||
| /** | ||
| * Wrapper around SLF4J logger facade. | ||
| * | ||
| * @param level net.spy.compat.log.Level level. | ||
| * @param message object message | ||
| * @param e optional throwable | ||
| */ | ||
| @Override | ||
| public void log(Level level, Object message, Throwable e) { | ||
| if(level == null) { | ||
| level = Level.FATAL; | ||
| } | ||
|
|
||
| switch(level) { | ||
| case TRACE: | ||
| logger.trace(message.toString(), e); | ||
| break; | ||
| case DEBUG: | ||
| logger.debug(message.toString(), e); | ||
| break; | ||
| case INFO: | ||
| logger.info(message.toString(), e); | ||
| break; | ||
| case WARN: | ||
| logger.warn(message.toString(), e); | ||
| break; | ||
| case ERROR: | ||
| logger.error(message.toString(), e); | ||
| break; | ||
| case FATAL: | ||
| logger.error(message.toString(), e); | ||
| break; | ||
| default: | ||
| logger.error("Unhandled Logging Level: " + level | ||
| + " with log message: " + message.toString(), e); | ||
| } | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.