chore: Move assets to separate toml file #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinblackman
force-pushed
the
external-assets
branch
from
294615b
to
0c71514
Compare
dustinblackman
force-pushed
the
external-assets
branch
2 times, most recently
from
dbf9a1c
to
e4e46b5
Compare
dustinblackman
force-pushed
the
external-assets
branch
from
e4e46b5
to
ed3b1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This refactors the syntax and theme assets that are managed and downloaded when building Oatmeal. Configurations now live in a
assets.tomlfile, porting what previously existed in build.rs.Additionally to the previous variables, each asset now as a
nix-hashthat's generated by runningcargo xtask hash-assetsthat will later be used to create a Nix package in the official repository.Lastly, syntaxes and themes can now be configured to be downloaded outside of running
cargo buildby setting theOATMEAL_BUILD_DOWNLOADED_SYNTAXES_DIRandOATMEAL_BUILD_DOWNLOADED_THEMES_DIRenvironment variables. When set,build.rswill use files available in those directories rather than downloading the assets defined inassets.toml.