InnerException logging

[danielgindi]

In many cases - we need a lot more info, like inner exceptions. Which could go to multiple levels.

In NLog File layout we can specify something like this: <target name="f" type="File" layout="${message}${onexception:EXCEPTION OCCURRED\:${exception:format=type,message,method:maxInnerExceptionLevel=5:innerFormat=shortType,message,method}}" /> to log inner exceptions, and with multiple levels.
https://nlog-project.org/2011/04/20/exception-logging-enhancements.html

You could take a look here to see how they handle multiple InnerExceptions, AggregateExceptions etc.

[dustinchilson]

This seems like a great add.

The only issue I see is, there's a limit to how much you can stuff in each graylog message.

https://github.com/dustinchilson/NLog.Targets.GraylogHttp/blob/master/src/NLog.Targets.GraylogHttp/GraylogMessageBuilder.cs#L56

I typically handle this situation in the application code and just walk the ex tree and log them separately.

Would you think it's reasonable for a setting to do that automatically?

[danielgindi]

The only issue I see is, there's a limit to how much you can stuff in each graylog message.

Then it should be trimmed right?

Would you think it's reasonable for a setting to do that automatically?

Yes because it would be duplication of code to do it everywhere you have a logger.Error(ex) call.
Also if you have several NLog configurations, one of them sends to a file, another to graylog - it's weird if one can log inner exceptions and the other dont.