If flags are used instead of positional arguments, also expose cert and key paths falling back to existing defaults.

[mcroydon]

This builds on top of @cespare's conversion from positional arguments to flags and doesn't make a lot of sense otherwise, so feel free to leave this on the cutting room floor. Adding optional flags for the certificate and key paths makes it nicer to use pollen without having to put them in /etc.

I'd also second the vote for flags over positional arguments. It's nice to be able to run pollen stand alone without any arguments and get the author-provided defaults. What you get for free with -h is nice too:

$ pollen -h
Usage of pollen:
-bytes=64: The size in bytes to transmit and receive each time
-cert="/etc/pollen/cert.pem": The full path to cert.pem
-device="/dev/urandom": The device to use for reading and writing random data
-http-addr=":80": The HTTP address:port on which to listen
-https-addr=":443": The HTTPS address:port on which to listen
-key="/etc/pollen/key.pem": The full path to key.pem

I totally respect the decision if positional arguments are the way to go for your use case.

[dustinkirkland]

Fantastic idea, Matthew.

I've merged your suggestion into the upstream bzr branch on Launchpad, and
sync'd that back here to github.

Cheers!

:-Dustin

Dustin Kirkland
Ubuntu Core Developer

On Tue, Feb 18, 2014 at 10:01 PM, Matt Croydon notifications@github.comwrote:

This builds on top of @cespare https://github.com/cespare's conversion
from positional arguments to flags and doesn't make a lot of sense
otherwise, so feel free to leave this on the cutting room floor. Adding
optional flags for the certificate and key paths makes it nicer to use
pollen without having to put them in /etc.

I'd also second the vote for flags over positional arguments. It's nice to
be able to run pollen stand alone without any arguments and get the
author-provided defaults. What you get for free with -h is nice too:

$ pollen -h
Usage of pollen:
-bytes=64: The size in bytes to transmit and receive each time
-cert="/etc/pollen/cert.pem": The full path to cert.pem
-device="/dev/urandom": The device to use for reading and writing random
data
-http-addr=":80": The HTTP address:port on which to listen
-https-addr=":443": The HTTPS address:port on which to listen
-key="/etc/pollen/key.pem": The full path to key.pem

I totally respect the decision if positional arguments are the way to go

for your use case.

You can merge this Pull Request by running

git pull https://github.com/mcroydon/pollen flags

Or view, comment on, or merge it at:

#5
Commit Summary

• Don't create the entropy device if it doesn't exist
• Use flags rather than positional arguments, and plumb bytes argument
  through
• If positional arguments are replaced with flags, also allow cert or
  key to be specified falling back to existing default values.

File Changes

• M debian/pollen.defaulthttps://github.com/If flags are used instead of positional arguments, also expose cert and key paths falling back to existing defaults. #5/files#diff-0(12)
• M debian/pollen.upstarthttps://github.com/If flags are used instead of positional arguments, also expose cert and key paths falling back to existing defaults. #5/files#diff-1(10)
• M pollen.8https://github.com/dustinkirkland/pollen/pull/5/files#diff-2(10)
• M pollen.gohttps://github.com/If flags are used instead of positional arguments, also expose cert and key paths falling back to existing defaults. #5/files#diff-3(31)

Patch Links:

• https://github.com/dustinkirkland/pollen/pull/5.patch
• https://github.com/dustinkirkland/pollen/pull/5.diff

Reply to this email directly or view it on GitHubhttps://github.com//pull/5
.