Manifest entry added to POM file for Modular compatibility #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a modular project, there is a file that is central to the project that manages the inclusion and scope of dependencies in the project. There is a mandate that requires module names to follow the domain naming schema, so when developers use a library that cannot be identified by a proper name, it becomes difficult to use the library.
Adding
Automatic-Module-Name
to the manifest file solves this problem, by giving the library a proper name that can be used in amodule-info.java
file within a modular project.I added the manifest entry to the
maven-source-plugin
.I also updated all of the plugin versions in the POM file.
And I wasn't quite sure why you have this line under your
maven-release-plugin
In my IDE it throws an error ... this is how I usually have my release plugin configured and then when I deploy, I get prompted for my gpg password, which has a long timeout set so that if I have to deploy again (because of some problem), I don't get prompted again.