Update nearly all dependencies #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most notably, React to React 18
rivertam
commented
Jun 16, 2023
| containerRef.current.offsetHeight / 2, | ||
| )) | ||
| const rndPos = () => { | ||
| const container = containerRef.current; |
There was a problem hiding this comment.
Here's an example of a bug I fixed (but there are more like it). It errors during the render function when the container unmounts. I think it would get swallowed in production, but on the dev server it shows up as an error blocking the screen that you have to X out
|
Ugh the main boids example on the front page isn't full height and I can't quite figure out how to fix it. That's the only actual issue remaining that I can see, unless you count the fact that the docs themselves are in React 17 emulation mode because Docusaurus doesn't actually support React 18 |
|
Yeah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably, this should be more explicitly compatible with React 18.
There are still problematic peer dependencies because much of Docusaurus declares React 16-17 being supported and I don't think there are more recent versions of Docusaurus that do (though I think v3 will come out at some point and support React 18).
There are a lot of little new bugs with the docs, I think exclusively to do with mount/dismount lifecycle of the way that various examples in the docs work. I fixed a couple of them, but I didn't want to chase all of them down. So far, the only ones I've seen should just be a console.error in production.