This repository has been archived by the owner on Aug 24, 2023. It is now read-only.
Fix concatenation for URIs, update Gem to latest deps, fix spelling errors. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm trying to use this in a Rails app, but the scopes on authentication URIs seem to be misshapen. Rails throws
URI::InvalidURIError (bad URI(is not URI?)
using the 0.0.2 version.I fixed it by concatenating them with '+', got it to get both the OAuth request code and the access token with these changes. And I've updated the tests, and fixed a spelling error with them that threw a couple of failures.
And I've took the liberty of updating the gem's dependencies, feel free to request a new PR without this (or anything you see that looks off).
Apologies about the evasive diff, something must've gone wrong on the way to Github, it only diff'd the lines I changed on my machine! 😄