Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

Fix concatenation for URIs, update Gem to latest deps, fix spelling errors. #1

Merged
merged 3 commits into from
Oct 27, 2013

Conversation

MattRyder
Copy link
Contributor

Hi there,

I'm trying to use this in a Rails app, but the scopes on authentication URIs seem to be misshapen. Rails throws URI::InvalidURIError (bad URI(is not URI?) using the 0.0.2 version.

I fixed it by concatenating them with '+', got it to get both the OAuth request code and the access token with these changes. And I've updated the tests, and fixed a spelling error with them that threw a couple of failures.

And I've took the liberty of updating the gem's dependencies, feel free to request a new PR without this (or anything you see that looks off).

Apologies about the evasive diff, something must've gone wrong on the way to Github, it only diff'd the lines I changed on my machine! 😄

@dustinlakin
Copy link
Owner

Looks great, I haven't used this in a few months. Thanks for checking it out and help keeping it updated.

dustinlakin added a commit that referenced this pull request Oct 27, 2013
Fix concatenation for URIs, update Gem to latest deps, fix spelling errors.
@dustinlakin dustinlakin merged commit 28e26ad into dustinlakin:master Oct 27, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants