Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add eslint-plugin-compat #45

Closed
amilajack opened this issue Jan 2, 2017 · 5 comments
Closed

RFC: Add eslint-plugin-compat #45

amilajack opened this issue Jan 2, 2017 · 5 comments

Comments

@amilajack
Copy link
Contributor

amilajack commented Jan 2, 2017

This eslint plugin lints against APIs that are only supported by target browsers 馃帀 Would a PR for adding this plugin be welcome?

Here's a demo of it in action

demo of plugin usage

@jfmengels
Copy link
Collaborator

Absolutely :)

@ntwb
Copy link
Contributor

ntwb commented Jan 2, 2017

As an aside, from a quick peek, @amilajack have you thought about using browserlist?

https://github.com/ai/browserslist

@amilajack
Copy link
Contributor Author

@ntwb What does browserlist do?

@ntwb
Copy link
Contributor

ntwb commented Jan 2, 2017

@amilajack It also uses the caniuse database, though you can have much more detailed queries of what browsers to test against, check the examples at https://github.com/ai/browserslist#queries

@amilajack
Copy link
Contributor Author

@ntwb I see. So are you suggesting that eslint-plugin-compat use browserslist to query caniuse? eslint-plugin-compat is aimed at linting the cross-browser compatibility of apis being used. browserslist 'Shares browsers list between different front-end tools'. Two very different things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants