Get property names from __proto__ too
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this pull request and all of the research! And a huge thanks for the big wall of text on #2. Super helpful. I apologize for my delayed response. This all looks great and running this linked in eslint-plugin-no-use-extend-native has tests passing over there still, so all looks good to me. I'll get obj-props 1.3.0 published once this passes on CI. |
|
Published 1.3.0 https://www.npmjs.com/package/obj-props. Thank you for this! |
|
I'm glad I was able to help 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2.
fromNode10should not be necessary anymore.I'm not sure if the added properties (
bind,constructor,toString, etc) are a problem or not.