Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get username for lightweight tag from git, not hg #77

Open
dusty-phillips opened this issue Apr 28, 2013 · 2 comments
Open

Get username for lightweight tag from git, not hg #77

dusty-phillips opened this issue Apr 28, 2013 · 2 comments

Comments

@dusty-phillips
Copy link
Owner

In #58, PaulPrice fixed lightweight tags such that the username is set to the default mercurial username on the host system, rather than None. This is a much improved interface.

However, I now think it would make more sense to set the username to the default git username and e-mail when pushing to mercurial. At the time that gitifyhg is exporting to mercurial, it knows (or ought to know) more about the state of the git repo than the mercurial one.

Mercurial has no concept of lightweight tags; it is therefore probably more useful for gitifyhg users to use only heavyweight tags. However, there is no reason to explicitly prohibit lightweight tags; we just have to do the heavyweightifying automatically.

@PaulPrice
Copy link
Contributor

This is a good idea. Another reason is that since the user is using gitifyhg, he may not have Mercurial set up properly with the author name.

@felipec
Copy link
Contributor

felipec commented May 4, 2014

I've fixed this.

felipec@a2912f4

felipec added a commit to felipec/gitifyhg that referenced this issue May 4, 2014
Ported from git-remote-hg.

Fixes dusty-phillips#77.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants