Merge pull request #15 from sytranvn/webpack-prod-mode

dutiyesh · Oct 13, 2021 · e2df8d5 · e2df8d5
2 parents 7f54be8 + 262107a
commit e2df8d5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/config/webpack.common.js b/config/webpack.common.js
@@ -17,7 +17,6 @@ const common = {
     // the filename template for entry chunks
     filename: '[name].js',
   },
-  devtool: 'source-map',
   stats: {
     all: false,
     errors: true,

diff --git a/templates/devtools/config/webpack.config.js b/templates/devtools/config/webpack.config.js
@@ -6,12 +6,13 @@ const common = require('./webpack.common.js');
 const PATHS = require('./paths');
 
 // Merge webpack configuration files
-const config = merge(common, {
+const config = (env, argv) => merge(common, {
   entry: {
     devtools: PATHS.src + '/devtools.js',
     panel: PATHS.src + '/panel.js',
     background: PATHS.src + '/background.js',
   },
+  devtool: argv.mode === 'production' ? false : 'source-map'
 });
 
 module.exports = config;
diff --git a/templates/override-page/config/webpack.config.js b/templates/override-page/config/webpack.config.js
@@ -6,11 +6,12 @@ const common = require('./webpack.common.js');
 const PATHS = require('./paths');
 
 // Merge webpack configuration files
-const config = merge(common, {
+const config = (env, argv) => merge(common, {
   entry: {
     app: PATHS.src + '/app.js',
     background: PATHS.src + '/background.js',
   },
+  devtool: argv.mode === 'production' ? false : 'source-map'
 });
 
 module.exports = config;
diff --git a/templates/popup/config/webpack.config.js b/templates/popup/config/webpack.config.js
@@ -6,12 +6,13 @@ const common = require('./webpack.common.js');
 const PATHS = require('./paths');
 
 // Merge webpack configuration files
-const config = merge(common, {
+const config = (env, argv) => merge(common, {
   entry: {
     popup: PATHS.src + '/popup.js',
     contentScript: PATHS.src + '/contentScript.js',
     background: PATHS.src + '/background.js',
   },
+  devtool: argv.mode === 'production' ? false : 'source-map'
 });
 
 module.exports = config;