Expand volume type filters and add storageclass filters #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benosman Have you ever tested this feature? and please add a Additionally, Could you give some more specific examples to explain this PR? I don't know exactly what your ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is similar to #10, in that it supports filtering by storage classes, but it also expands the volume type matching.
It can match against all volume types except
"hostPath", "secret", "configMap", "emptyDir"which are always excluded due to not being supported/recommended for use with velero restic.For persistentVolumeClaims it checks against the filters using both "persistentVolumeClaim" and if that is not present it uses the underlying volume type of the claim to match against filters.