Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The insert_nums command doesn't seem to be working on ST3 Build 3065 #23

Closed
dufferzafar opened this issue Nov 18, 2014 · 1 comment
Closed

The insert_nums command doesn't seem to be working on ST3 Build 3065 #23

dufferzafar opened this issue Nov 18, 2014 · 1 comment
Assignees
@duydao
Labels
bug
Milestone
1.4.1

Comments

@dufferzafar
Copy link

\i0, \i1 commands stopped working for me while everything else was working as expected.

I couldn't figure out what exactly was causing the bug, but got things working for myself by changing the following lines (in text_pastry.py, Line 600):

self.history_manager.append(data={"command": "insert_nums", "args": {"current": "1", "step": "1", "padding": "1"}}, label=item.label)
self.window.run_command("insert_nums", {"current": "1", "step": "1", "padding": "1"})

with:

self.history_manager.append(data={"command": "text_pastry_range", "args": {'start': 1, 'step': 1, 'padding': 1}}, label=item.label)
self.window.run_command("text_pastry_range", {'start': 1, 'step': 1, 'padding': 1})
@duydao duydao added the bug label Nov 18, 2014
@duydao duydao added this to the 1.4.1 milestone Nov 18, 2014
@duydao duydao self-assigned this Nov 18, 2014
duydao added a commit that referenced this issue Nov 18, 2014
@duydao
Hotfix for #23
18ad3f6 
remove insert nums-dependency in menu/history, keep compatibility for old history entries.
duydao added a commit that referenced this issue Nov 18, 2014
@duydao
Hotfix for #23
a8b553d 
- Remove insert-nums reference
- Fix call/history entry
- Fix Command Palette entries
- Ensure compatibility for older history entries
@duydao
Copy link
Owner

duydao commented Nov 18, 2014

Thanks for reporting this. I've missed some old references to insert_nums, I've changed to code as suggested and fixed othere references as well.

Thanks for using Text Pastry!

@duydao duydao closed this as completed Nov 18, 2014
duydao added a commit that referenced this issue Dec 14, 2014
@duydao
Squashed commit of the following:
4096504 
commit b2576dc
Author: Duy Dao <duy@daonet.ch>
Date:   Sun Dec 14 21:57:44 2014 +0100

    Added x-arg support, date range and autostep

commit d534e78
Author: Duy Dao <duy@daonet.ch>
Date:   Sun Nov 23 20:00:48 2014 +0100

    update readme, change date range to 1.4.3

commit faa5756
Merge: 8b0c069 348b6eb
Author: Duy Dao <duy@daonet.ch>
Date:   Sun Nov 23 19:56:11 2014 +0100

    Merge branch 'master' into develop

commit 8b0c069
Author: Duy Dao <duy@daonet.ch>
Date:   Tue Nov 18 21:50:44 2014 +0100

    update readme, add 1.4.1

commit 18ad3f6
Author: Duy Dao <duy@daonet.ch>
Date:   Tue Nov 18 21:33:45 2014 +0100

    Hotfix for #23

    remove insert nums-dependency in menu/history, keep compatibility for old history entries.

commit eaedfe7
Author: Duy Dao <duy@daonet.ch>
Date:   Sat Nov 15 18:52:26 2014 +0100

    added end-of-the-month command, removed print, renamed "repeat" to "step_size"

    alias:

    eom | end-of-month | eotm | end-of-the-month
    ldom | last-day-of-month | ldotm | last-day-of-the-month

commit 8fa00de
Author: Duy Dao <duy@daonet.ch>
Date:   Sat Nov 15 02:45:05 2014 +0100

    fix

commit f1d10d9
Author: Duy Dao <duy@daonet.ch>
Date:   Sat Nov 15 02:44:06 2014 +0100

    update readme

commit 1a9754e
Author: Duy Dao <duy@daonet.ch>
Date:   Sat Nov 15 02:40:20 2014 +0100

    Added date range feature

    - new commands day/week/month/year X
    - X stands for the number of dates. Used if there is no multiselect or if X < number of selections
    - new setting "date_format"
    - new setting list "parse_date_format"
    - selected a single date to use it as start date and X for the amount of dates that should be generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duydao duydao

Labels
bug
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@duydao @dufferzafar