feat: add /zookeeper explorer #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+244
to
+248
| title: 'Zookeeper', | ||
| href: '/zookeeper?path=/', | ||
| description: | ||
| 'Exposes data from the Keeper cluster defined in the config', | ||
| icon: RollerCoasterIcon, |
There was a problem hiding this comment.
suggestion (code_refinement): Consider adding a tooltip for the new Zookeeper menu item for consistency.
All other menu items have tooltips that provide additional context on hover. Adding a tooltip to the Zookeeper item would maintain UI consistency and enhance user experience.
Suggested change
| title: 'Zookeeper', | |
| href: '/zookeeper?path=/', | |
| description: | |
| 'Exposes data from the Keeper cluster defined in the config', | |
| icon: RollerCoasterIcon, | |
| title: 'Zookeeper', | |
| href: '/zookeeper?path=/', | |
| description: | |
| 'Exposes data from the Keeper cluster defined in the config', | |
| icon: RollerCoasterIcon, | |
| tooltip: 'Manage and monitor your Zookeeper clusters', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #216