Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter scenario mouse click is flaky #26

Closed
duyminh1998 opened this issue Nov 19, 2023 · 2 comments · Fixed by #28
Closed

Enter scenario mouse click is flaky #26

duyminh1998 opened this issue Nov 19, 2023 · 2 comments · Fixed by #28
Labels
bug Something isn't working

Comments

@duyminh1998
Copy link
Owner

Summary

Sometimes the MoveMouseEnterScenario.ps1 script is flaky and we miss the "Enter scenario" button

Steps to reproduce

  1. Run the floridistan/restart_demo.py several times and you might see the mouse gets moved beyond the "Enter scenario" button.

What is the current bug behavior?

MoveMouseEnterScenario.ps1 does not always guarantee the movement of the mouse to the "Enter scenario" button and click on it

What is the expected correct behavior?

MoveMouseEnterScenario.ps1 will always move the mouse to the "Enter scenario" button and click on it

Relevant logs and/or screenshots

image

@duyminh1998 duyminh1998 added the bug Something isn't working label Nov 19, 2023
duyminh1998 added a commit that referenced this issue Nov 19, 2023
@duyminh1998
Copy link
Owner Author

Per this commit, we should think about making a clicker class that will run .bat or .ps1 scripts to click something (usually to close a window), but also check that the window has indeed been closed and restart the script as necessary. This will remove some flakiness induced by timing issues with our code. One piece of code that might break is the closeScenarioEndMessage.bat script, which closes the message that displays when the scenario ends. If this message takes too slow to show up and we fire the script before its appearance, we will throw off our timing.

@duyminh1998 duyminh1998 linked a pull request Nov 19, 2023 that will close this issue
duyminh1998 added a commit that referenced this issue Nov 19, 2023
* add feature for protocol to restart scenario

* add feature to record when a scenario has ended

* add restart feature to cmo_env

* add feature to close the popup message when we end a scen

* comment out tests that are only ran locally

* let cmo_env close popup message when scenario ends

* implement restart feature, can now do training loops

* make a demo for restarting the scenario

* add some timing fixes

* correct variable name

* clean up unused sleep in demos

* clean up steam demo

* create base agent and function to run loop

* clean up restart demo

* update steam demo

* add a restart demo to steam demo scen

* update README

* update README

* update README

* clean up setup

* simplifying cmo_env params

* temp fix

* clean up

* comment out tests that require CMO to be running

* remove tests that require CMO to be running

* note potential fixes

* fix issue where Comments is not set properly upon load

* add note for issue #26

* working fix

* remove redundant steam demo

* increase timing to address flakiness

* clean comments

* clean comments

* update docs on demos

* update docs for sample agents

* add tests for protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Delivered
1 participant