Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario ending might not be recorded correctly #33

Open
duyminh1998 opened this issue Nov 19, 2023 · 0 comments
Open

Scenario ending might not be recorded correctly #33

duyminh1998 opened this issue Nov 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@duyminh1998
Copy link
Owner

Describe the bug
Related to issue #25, when a scenario ends in-game, the Scenario has Ended event might not fire properly and the environment might not know that the scenario has ended and get stuck.

To Reproduce
Steps to reproduce the behavior:

  1. Load the scen/steam_demo_restart.scen scenario.
  2. Disable the Scenario has Ended event.
  3. Let the scenario run.
  4. See error

Expected behavior
We need to know when the Scenario has Ended event has not fired properly and handle it accordingly. Currently, we can also use the CMOEnv::end_game() function to end the game.
@duyminh1998 duyminh1998 added the bug Something isn't working label Nov 19, 2023
@duyminh1998 duyminh1998 added this to the 1.3.0 milestone Nov 20, 2023
@duyminh1998 duyminh1998 mentioned this issue Nov 22, 2023
Closed
@duyminh1998 duyminh1998 removed this from the 1.3.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
@duyminh1998's pyCMO
Status: Tech Debt
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duyminh1998