feat: support dispatch action in onError hook

dvajs · Oct 9, 2016 · 7f2575a · 7f2575a
1 parent 6fb6fa6
commit 7f2575a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/createDva.js b/src/createDva.js
@@ -95,7 +95,7 @@ export default function createDva(createOpts) {
       const onErrorWrapper = (err) => {
         if (err) {
           if (typeof err === 'string') err = new Error(err);
-          onError(err);
+          onError(err, app._store.dispatch);
         }
       };
 

diff --git a/test/effects-test.js b/test/effects-test.js
@@ -105,13 +105,17 @@ describe('effects', () => {
   it('onError', () => {
     const errors = [];
     const app = dva({
-      onError: (error) => {
+      onError: (error, dispatch) => {
         errors.push(error.message);
+        dispatch({ type: 'count/add' });
       }
     });
     app.model({
       namespace: 'count',
       state: 0,
+      reducers: {
+        add(state) { return state + 1; },
+      },
       effects: {
         *addDelay() {
           throw new Error('effect error');
@@ -122,6 +126,7 @@ describe('effects', () => {
     app.start();
     app._store.dispatch({ type: 'count/addDelay' });
     expect(errors).toEqual(['effect error']);
+    expect(app._store.getState().count).toEqual(1);
   });
 
   it('type: takeLatest', (done) => {