Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: use typings exported from @types/react-redux #2136

Merged
merged 1 commit into from
Jun 26, 2019
Merged

deps: use typings exported from @types/react-redux #2136

merged 1 commit into from
Jun 26, 2019

Conversation

meowtec
Copy link
Contributor

@meowtec meowtec commented Jun 24, 2019 •
edited
Loading

#2133

补充了 d.ts 里的 useSelector 等 API.
interface 类的目前只 export 了 DispatchProp，这个比较常用。@types/react-redux 暴露的 interfaces 太多，就没有一一处理。

@coveralls
Copy link

coveralls commented Jun 24, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 87.282% when pulling 6f8dd11 on meowtec:types-react-redux into 80ae4c7 on dvajs:master.

sorrycc
sorrycc requested changes Jun 25, 2019
View reviewed changes
packages/dva/index.d.ts
import {
connect, connectAdvanced, useSelector, useDispatch, useStore,
DispatchProp,
} from 'react-redux';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import 后并没有 export，本地没验证过吧。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好了，本地验了一下

@sorrycc sorrycc merged commit 3c6f258 into dvajs:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorrycc sorrycc sorrycc requested changes

Assignees
No one assigned
Labels
pr(enhancement)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meowtec @coveralls @sorrycc