Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: history listener subscription execute multiple times #2230

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Oct 28, 2019

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@coveralls
Copy link

coveralls commented Oct 28, 2019

Coverage Status

Coverage decreased (-1.05%) to 86.635% when pulling 4fac31d on fix/history-listen-subscription into 0e763de on master.

@sorrycc sorrycc merged commit 869f530 into master Oct 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/history-listen-subscription branch October 28, 2019 14:21
@yoyo837
Copy link

yoyo837 commented Oct 29, 2019

这个修改或者是 2.6.0-beta.14 ---> 2.6.0-beta.15 更新带来的依赖修改,会导致部分浏览器不跳转或者警告你当前跳转的地址就是当前地址。 Broken!

@songhuizhang
Copy link

这次修复会引起路由哈希值改变无效,反复重置位上一级哈希。
也就是上楼说的路由不跳转问题。。。

@sorrycc
Copy link
Member Author

sorrycc commented Oct 31, 2019

@yoyo837 @songhuizhang 是 connected-react-router 的版本问题吗?有没有复现步骤?

@yoyo837
Copy link

yoyo837 commented Nov 1, 2019

可能是,beta.15connected-react-router的版本由6.5.2变成了6.3.2, 我升级到beta.16试一试。

@yoyo837
Copy link

yoyo837 commented Nov 1, 2019

beta.16不能解决这个问题。复现的话,可能得后面找时间提供了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在全局model的history.listen中调用dispatch,同时Link的to属性添加query参数会导致栈溢出
4 participants