Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts declare dynamic.setDefaultLoadingComponent #2269

Closed
wants to merge 8 commits into from
Closed

ts declare dynamic.setDefaultLoadingComponent #2269

wants to merge 8 commits into from

Conversation

becarchal
Copy link
Contributor

@becarchal becarchal commented Jan 1, 2020 •
edited

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@coveralls
Copy link

coveralls commented Jan 1, 2020 •
edited

Coverage Status

Coverage remained the same at 86.493% when pulling 6da249f on becarchal:master into a5e4ca5 on dvajs:master.

@stale
Copy link

stale bot commented Mar 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 1, 2020
@stale stale bot closed this Mar 8, 2020
laogui
laogui reviewed Jun 11, 2020
View reviewed changes
Copy link

@laogui laogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version missing the declare of setDefaultLoadingComponent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laogui laogui laogui left review comments

Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@becarchal @coveralls @laogui