Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract field #35

Merged
merged 2 commits into from Jan 22, 2022
Merged

Add abstract field #35

merged 2 commits into from Jan 22, 2022

Conversation

theotheo
Copy link
Contributor

@theotheo theotheo commented Jan 22, 2022

Not sure I account all thing, but at least I've check it and it works
image

Copy link
Owner

@dvanoni dvanoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theotheo this is great! Thank you so much for contributing! I've pulled your PR and tested locally. Everything looks good to me!

@dvanoni dvanoni merged commit 7d2a55f into dvanoni:main Jan 22, 2022
@jigarp12892
Copy link

Hello @theotheo and @dvanoni , another awesome addition! Is there any way I can trigger this change to existing entries in the notion database? A new paper added to the zotero collection puts the Abstract in Notion just fine, but existing ones don't change.

I even tried creating a dummy 'edit' in Zotero like adding a tag or something so that notero re-syncs, but it does not trigger the abstract being pulled in.

@dvanoni
Copy link
Owner

dvanoni commented Jan 25, 2022

@jigarp12892 doing an edit like that is probably the best way to trigger the re-sync for now (until #21 gets implemented). I was able to get that to work as show in the video below.

I'm curious why it's not working for you. 🤔 Do you get any errors during the sync? Would you mind opening Tools > Developer > Error Console from the Zotero menu before syncing and let me know if you notice any messages there?

CleanShot.2022-01-24.at.21.02.53.mp4

@jigarp12892
Copy link

jigarp12892 commented Jan 25, 2022

Hi @dvanoni , I figured out the issue. There was a problem with the abstract of the paper I was using for all the testing. I tried others and it worked. Thanks!

@dvanoni
Copy link
Owner

dvanoni commented Jan 25, 2022

@jigarp12892 I'm glad you were able to figure it out! I'm curious what the problem was with the abstract. Were there special characters or something that was causing the sync not to work? Or did Zotero just not have the abstract at all?

@jigarp12892
Copy link

Zotero did not pull in the abstract at all. I guess it was silly of me to assume that it always will :P. So nothing on Notero's end was the problem. I even tried pulling in an abstract with special characters in. It works perfectly !

@dvanoni
Copy link
Owner

dvanoni commented Jan 25, 2022

Great! Thanks for doing that extra testing @jigarp12892!

@jigarp12892
Copy link

Happy to help @dvanoni. In fact, you can count on me if you need a minion to do more stress testing. I would love to contribute as a dev, but I'm afraid the cards might start flowing from 'completed' to 'in process' 🤣

@pmmendoza
Copy link

Hi @dvanoni short follow-up on this bc. I don't know how to reach out to you otherwise - should any changes in Notion (e.g. addition of a Tag) also be synced back to zotero?

If not is this a possible feature or is it too complex (risk of duplicating / messing up things);

@dvanoni
Copy link
Owner

dvanoni commented Jan 27, 2022

@pmmendoza, that's a good question! Unfortunately, it's not possible for the plugin to be notified of any updates within Notion.

The question of syncing updates from Notion back into Zotero was also asked by someone in the Zotero forums. It would be neat, but it's unfortunately beyond the scope of the plugin. Getting updates from Notion into Zotero would require setting up a hosted service that subscribes to webhooks from Notion and then uses the Zotero API to update items in Zotero. Notion has yet to release official webhook support, but there are some third-party tools that can be used for this. In theory this is technically possible, but it would be a separate project from the plugin and something I wouldn't be able to take on anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Abstracts from Zotero as a property in Notion Database
4 participants