Make Makefile more portable #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poti!!! No way!!! 😄 |
|
I tested your BSD syntax and it run on my laptop too. Testing it in CI too. |
dvarrazzo
force-pushed
the
makefile-posix-sed
branch
from
fa9d768
to
b9f3b23
Compare
|
Ok, I've used the syntax you proposed for the expressions, but removed the if because they seem to work well on GNU sed too. Thank you very much for the contribution. Gabri says hi 🙂 |
Even better! good stuff man. Let's get in touch sometime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there Daniele, long time uh?? Miss our barbecues in Acton Town back in the day! :D
I started using this very helpful extension on a personal project and was amazed to find out you were the author. Small world.
Anyway, I had the same problem as described in #20, went ahead and added a small workaround for adapting the
sedsyntax and was able to compile it in Mac OS without any issues.Differently from #20, the tests seem to be passing. Not sure why, but I hope this is helpful.
Cheers!