-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [testenv:pypy-3.8] for tox #125
Conversation
If we merge this, will it work for both tox 3 and 4? If so we can merge this and drop the relative change you had to make in #120. |
Hmm, no it doesn't. A little too confident here I guess... I'm looking. |
tox 3 $ rm -rf venv; python3.10 -m venv venv; venv/bin/pip install 'tox<4'; venv/bin/tox -re pypy-3.8
Collecting tox<4
Using cached tox-3.27.1-py2.py3-none-any.whl (86 kB)
Collecting packaging>=14
Using cached packaging-22.0-py3-none-any.whl (42 kB)
Collecting pluggy>=0.12.0
Using cached pluggy-1.0.0-py2.py3-none-any.whl (13 kB)
Collecting py>=1.4.17
Using cached py-1.11.0-py2.py3-none-any.whl (98 kB)
Collecting tomli>=2.0.1
Using cached tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0
Using cached virtualenv-20.17.1-py3-none-any.whl (8.8 MB)
Collecting filelock>=3.0.0
Using cached filelock-3.8.2-py3-none-any.whl (10 kB)
Collecting six>=1.14.0
Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting distlib<1,>=0.3.6
Using cached distlib-0.3.6-py2.py3-none-any.whl (468 kB)
Collecting platformdirs<3,>=2.4
Using cached platformdirs-2.6.0-py3-none-any.whl (14 kB)
Installing collected packages: distlib, tomli, six, py, pluggy, platformdirs, packaging, filelock, virtualenv, tox
Successfully installed distlib-0.3.6 filelock-3.8.2 packaging-22.0 platformdirs-2.6.0 pluggy-1.0.0 py-1.11.0 six-1.16.0 tomli-2.0.1 tox-3.27.1 virtualenv-20.17.1
[notice] A new release of pip available: 22.2.2 -> 22.3.1
[notice] To update, run: /home/altendky/repos/setproctitle/venv/bin/python3.10 -m pip install --upgrade pip
GLOB sdist-make: /home/altendky/repos/setproctitle/setup.py
pypy-3.8 recreate: /home/altendky/repos/setproctitle/.tox/pypy-3.8
pypy-3.8 inst: /home/altendky/repos/setproctitle/.tox/.tmp/package/1/setproctitle-1.3.2.zip
pypy-3.8 installed: attrs==22.1.0,cffi==1.14.6,exceptiongroup==1.0.4,greenlet==0.4.13,hpy==0.0.3,iniconfig==1.1.1,packaging==22.0,pluggy==1.0.0,pytest==7.2.0,readline==6.2.4.1,setproctitle @ file:///home/altendky/repos/setproctitle/.tox/.tmp/package/1/setproctitle-1.3.2.zip,tomli==2.0.1
pypy-3.8 run-test-pre: PYTHONHASHSEED='121856314'
pypy-3.8 run-test: commands[0] | pytest
=========================================== test session starts ============================================
platform linux -- Python 3.8.12[pypy-7.3.7-final], pytest-7.2.0, pluggy-1.0.0
cachedir: .tox/pypy-3.8/.pytest_cache
rootdir: /home/altendky/repos/setproctitle
collected 28 items
tests/module_test.py ... [ 10%]
tests/setproctitle_test.py ...s.........ss..... [ 82%]
tests/setthreadtitle_test.py ... [ 92%]
tests/test_win32.py ss [100%]
====================================== 23 passed, 5 skipped in 1.66s =======================================
_________________________________________________ summary __________________________________________________
pypy-3.8: commands succeeded
congratulations :) tox 4 rm -rf venv; python3.10 -m venv venv; venv/bin/pip install 'tox>=4'; venv/bin/tox -re pypy-3.8
Collecting tox>=4
Using cached tox-4.0.12-py3-none-any.whl (143 kB)
Collecting chardet>=5.1
Using cached chardet-5.1.0-py3-none-any.whl (199 kB)
Collecting cachetools>=5.2
Using cached cachetools-5.2.0-py3-none-any.whl (9.3 kB)
Collecting tomli>=2.0.1
Using cached tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting virtualenv>=20.17.1
Using cached virtualenv-20.17.1-py3-none-any.whl (8.8 MB)
Collecting packaging>=22
Using cached packaging-22.0-py3-none-any.whl (42 kB)
Collecting pluggy>=1
Using cached pluggy-1.0.0-py2.py3-none-any.whl (13 kB)
Collecting colorama>=0.4.6
Using cached colorama-0.4.6-py2.py3-none-any.whl (25 kB)
Collecting filelock>=3.8.2
Using cached filelock-3.8.2-py3-none-any.whl (10 kB)
Collecting pyproject-api>=1.2.1
Using cached pyproject_api-1.2.1-py3-none-any.whl (11 kB)
Collecting platformdirs>=2.6
Using cached platformdirs-2.6.0-py3-none-any.whl (14 kB)
Collecting distlib<1,>=0.3.6
Using cached distlib-0.3.6-py2.py3-none-any.whl (468 kB)
Installing collected packages: distlib, tomli, pluggy, platformdirs, packaging, filelock, colorama, chardet, cachetools, virtualenv, pyproject-api, tox
Successfully installed cachetools-5.2.0 chardet-5.1.0 colorama-0.4.6 distlib-0.3.6 filelock-3.8.2 packaging-22.0 platformdirs-2.6.0 pluggy-1.0.0 pyproject-api-1.2.1 tomli-2.0.1 tox-4.0.12 virtualenv-20.17.1
[notice] A new release of pip available: 22.2.2 -> 22.3.1
[notice] To update, run: /home/altendky/repos/setproctitle/venv/bin/python3.10 -m pip install --upgrade pip
pypy-3.8: remove tox env folder /home/altendky/repos/setproctitle/.tox/pypy-3.8
.pkg: remove tox env folder /home/altendky/repos/setproctitle/.tox/.pkg
.pkg: install_requires> python -I -m pip install 'setuptools>=40.8.0' wheel
.pkg: _optional_hooks> python /home/altendky/repos/setproctitle/venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: get_requires_for_build_sdist> python /home/altendky/repos/setproctitle/venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: prepare_metadata_for_build_wheel> python /home/altendky/repos/setproctitle/venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: build_sdist> python /home/altendky/repos/setproctitle/venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
pypy-3.8: install_package_deps> python -I -m pip install pytest
pypy-3.8: install_package> python -I -m pip install --force-reinstall --no-deps /home/altendky/repos/setproctitle/.tox/.tmp/package/1/setproctitle-1.3.2.tar.gz
pypy-3.8: commands[0]> pytest
=========================================== test session starts ============================================
platform linux -- Python 3.8.12[pypy-7.3.7-final], pytest-7.2.0, pluggy-1.0.0
cachedir: .tox/pypy-3.8/.pytest_cache
rootdir: /home/altendky/repos/setproctitle
collected 28 items
tests/module_test.py ... [ 10%]
tests/setproctitle_test.py ...s.........ss..... [ 82%]
tests/setthreadtitle_test.py ... [ 92%]
tests/test_win32.py ss [100%]
====================================== 23 passed, 5 skipped in 1.71s =======================================
.pkg: _exit> python /home/altendky/repos/setproctitle/venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
pypy-3.8: OK (14.90=setup[12.66]+cmd[2.24] seconds)
congratulations :) (15.05 seconds) |
I understand if you still just don't want to deal with tox 4 quite yet. Maybe merge this fix and also keep the |
I don't understand. We can move to just tox >= 4 if this works. Either we merge this and use tox >= 4 in #120, or we drop this and keep tox 3 🙂 |
Oh, I thought you wanted both working. Regardless, this seems like improved consistency across the environments. I don't really care if you pick 3 or 4. The rest of the environments were already working in 3 before in CI and still work with 4 in CI so you can choose a single version but you aren't being forced to. |
Squashed and merged, thank you! |
tox 4 is triggering
ValueError: conflicting factors pypy, 3.8 in pypy-3.8
. https://github.com/dvarrazzo/py-setproctitle/actions/runs/3716382749/jobs/6302641135#step:5:39 This may relate to tox-dev/tox#2657, or maybe not, but adding the environment seemed to match the pattern for the rest.