-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build binary wheels on MacOS #96
Conversation
Here is the updated test.yaml that I have not PR'ed - feel free to copy-pasta. https://github.com/Chia-Network/py-setproctitle/blob/macos-packages/.github/workflows/test.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AOK
@dvarrazzo Please chuckle at my colleague who thought I needed a review in our normal dev process... |
@hoffmang9 thank you very much for this. @wjblanke don't tease your colleague 😛 About that test failing, |
I have seen that this patch had a lot of churn. Could you please squash what makes sense to be squashed to leave you the attribution? Thank you |
cf9c351
to
a996c86
Compare
Ah... fun with git... Anyway, that should make it clean and rebased on master. |
Thanks for your efforts! Is there anything we can do to move this forward? |
I have cherry-picked this change into master, to be released in 1.2.3. |
setproctitle 1.2.3 released, including binary packages for macOS. |
I've added the ability to build binary wheels for the Mac.
I was also going to add them to tests but the tests are failing for MacOS.
See for example - https://github.com/Chia-Network/py-setproctitle/runs/1794589488?check_suite_focus=true#step:5:34
Happy to open a next PR with the tests if that would be helpful. You can see that we took a stab at fixing a MacOS issue earlier - fb4641d
I've verified that the built wheels work on MacOS python 3.7.7 and 3.8.5