Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binary wheels on MacOS #96

Closed
wants to merge 1 commit into from

Conversation

hoffmang9
Copy link
Contributor

I've added the ability to build binary wheels for the Mac.

I was also going to add them to tests but the tests are failing for MacOS.

See for example - https://github.com/Chia-Network/py-setproctitle/runs/1794589488?check_suite_focus=true#step:5:34

Happy to open a next PR with the tests if that would be helpful. You can see that we took a stab at fixing a MacOS issue earlier - fb4641d

I've verified that the built wheels work on MacOS python 3.7.7 and 3.8.5

@hoffmang9
Copy link
Contributor Author

Here is the updated test.yaml that I have not PR'ed - feel free to copy-pasta.

https://github.com/Chia-Network/py-setproctitle/blob/macos-packages/.github/workflows/test.yml

@hoffmang9 hoffmang9 mentioned this pull request Jan 29, 2021
Copy link

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AOK

@hoffmang9
Copy link
Contributor Author

@dvarrazzo Please chuckle at my colleague who thought I needed a review in our normal dev process...

@dvarrazzo
Copy link
Owner

dvarrazzo commented Jan 30, 2021

@hoffmang9 thank you very much for this. @wjblanke don't tease your colleague 😛

About that test failing, OSError: [Errno 7] Argument list too long: '/bin/sh' seems a clear error thrown by your OS. Maybe you could parametrise the test so that on OSX it tries with a shorter env or you can skip it altogether if it starts not making sense.

@dvarrazzo
Copy link
Owner

I have seen that this patch had a lot of churn. Could you please squash what makes sense to be squashed to leave you the attribution? Thank you

@hoffmang9
Copy link
Contributor Author

Ah... fun with git... Anyway, that should make it clean and rebased on master.

@seifertm
Copy link

Thanks for your efforts! Is there anything we can do to move this forward?

@dvarrazzo
Copy link
Owner

I have cherry-picked this change into master, to be released in 1.2.3.

@dvarrazzo dvarrazzo closed this Apr 13, 2022
@dvarrazzo
Copy link
Owner

setproctitle 1.2.3 released, including binary packages for macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants