Return struct for insufficient balance error #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvcrn bump |
|
I again didn't receive an email for this PR. Apologies for the delay and thanks for the contribution! |
|
No worries. Thanks for the merge! Do you mind making a new hex package release? |
dvcrn
reviewed
Jul 9, 2018
| %{code: -2010, msg: "Account has insufficient balance for requested action."} = reason | ||
| } | ||
| }) do | ||
| {:error, %Binance.InsufficientBalanceError{reason: reason}} |
There was a problem hiding this comment.
Actually looking at it now, It might be better to sub-package this to something like %Binance.Error.InsufficientBalance{} and use %Binance.Error{} for all other errors that are not implements as their own struct yet.
That and 'InsufficientBalance' already implies that the account doesn't have enough balance for the action so enforcing a :reason key is probably not needed too
But we can refactor that at a later point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.