Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

space 0 not focusing on tree view #272

Closed
kibin opened this issue May 23, 2017 · 3 comments · Fixed by #294
Closed

space 0 not focusing on tree view #272

kibin opened this issue May 23, 2017 · 3 comments · Fixed by #294
Labels
bug

Comments

@kibin
Copy link

kibin commented May 23, 2017

After update to atom 1.17 space 0 doesn’t do anything
@dvcrn dvcrn added the bug label May 24, 2017
@clayrisser
Copy link
Contributor

Use SPACE + 1 instead

@jackcasey
Copy link
Contributor

jackcasey commented Oct 26, 2017 •
edited

This behaviour seems buggy. I came here to report it and foudnd this bug.

If you have 2 panes and a treeview I'd expect 1 and 2 to be the 2 panes and 0 to be treeview.
If you have 2 panes without a treeview, I'd still expect 1 and 2 to be the panes.
Instead 0 is pane 1 and 1 is pane 2 and 2 is the treeview. Which makes no sense to me and now I end up just grabbing the mouse ><;

@clayrisser
Copy link
Contributor

clayrisser commented Oct 26, 2017 •
edited

I think SPACE + w + h should take you to the panel. It would be nice if proton treated all panels like windows.

jackcasey pushed a commit to jackcasey/proton that referenced this issue Mar 20, 2018
fix(core) dvcrn#272 SPC-# now works as expected
83c1b2d 
Make it so that SPC 1-9 goes to the first 9 panes, and SPC 0 goes to treeview.
In order to be robust if it can't find a pane it will go to treeview.
Now ignores 'panels' entirely, I'm not sure what they are and panes are what
is working for me.
@jackcasey jackcasey mentioned this issue Mar 20, 2018
Merged
dvcrn pushed a commit that referenced this issue Mar 20, 2018
@jackcasey @dvcrn
fix(core) #272 SPC-# now works as expected (#294)
f9dac0c 
Make it so that SPC 1-9 goes to the first 9 panes, and SPC 0 goes to treeview.
In order to be robust if it can't find a pane it will go to treeview.
Now ignores 'panels' entirely, I'm not sure what they are and panes are what
is working for me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core) #272 SPC-# now works as expected jackcasey/proton
4 participants
@jackcasey @dvcrn @kibin @clayrisser