Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default theme, new default font #25

Merged
merged 3 commits into from
Dec 10, 2015
Merged

Conversation

dvcrn
Copy link
Owner

@dvcrn dvcrn commented Dec 9, 2015

Needs testing. PR for #23

Changes

  • default theme to material
  • default font to hack
  • softWrap to true

I can't really test the Hack integration because I already have Hack on my system. Can someone else check? :)

@geksilla
Copy link
Collaborator

geksilla commented Dec 9, 2015

@dvcrn on my Mac without Hack default font was set.

@dvcrn
Copy link
Owner Author

dvcrn commented Dec 9, 2015

@geksilla cool! can you inspect with the dev tools, go to a piece of text inside the editor and click on "computed styles"?

If it says 'Hack' in there, we are good!

screen shot 2015-12-09 at 6 50 42 pm

@geksilla
Copy link
Collaborator

geksilla commented Dec 9, 2015

@dvcrn, I'm currently on Linux. I've removed font, reopened atom and font-family is Hack. Works for me.

@geksilla
Copy link
Collaborator

geksilla commented Dec 9, 2015

Switched back to my local branch and font is default now. So your fix works 🆒

@dvcrn dvcrn changed the title Better default experience New default theme, new default font Dec 10, 2015
dvcrn added a commit that referenced this pull request Dec 10, 2015
New default theme, new default font
@dvcrn dvcrn merged commit c92c8bd into master Dec 10, 2015
dvcrn added a commit that referenced this pull request Dec 14, 2015
New default theme, new default font
@dvcrn dvcrn deleted the better-default-experience branch December 14, 2015 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants