Now using deep-merge and added pomodoro layer #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added pomodoro layer and fixed typo in git layer readme
sglyon
changed the title
|
I can't manage to stop the timer. On abort, the timer changes to "aborted" but just continues going down after that. I guess that's a bug in the pomodoro package? |
|
Yeah that does seem like a bug. It's a little curious though as it I thought it was working for me earlier today... |
Merged
|
Not sure if we should merge a bugged package in to be honest. The cool thing about proton is that it's curated so we could guarantee a certain level of quality |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added pomodoro layer and fixed typo in git layer readme