New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pane focus specific keybindings. refs #65 #72
Conversation
@geksilla this is a great start. Good work! I have a couple of comments:
|
[proton.lib.proton :as proton])) | ||
|
||
(defn select-window-fn [n] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this to be its own function, or could we jsut use panes/focus-on-item
in place of select-window-fn
in the keybindings map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:fx should be a function, so I wrap panes/focus-on-item into function that returns function + window number as argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't panes/focus-on-item
a function though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I see it. Nevermind. Haha sorry for being slow here
regarding first comment there is issue #40. I'll try to fix that in another PR. |
Very cool PR! Can't wait to give this a shot. Is there anything you want to add? Otherwise I'll merge this now |
@dvcrn nothing to add for now. I would like to add single label [0-9] instead of 10, but it requires do some refactoring for keybindings and don't want to break things for now. I'll try in another PR if you don't mind. |
Added pane focus specific keybindings. refs #65
👍 |
Added pane focus specific keybindings. refs #65
ping @dvcrn, @spencerlyon2 to review.