Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pane focus specific keybindings. refs #65 #72

Merged
merged 1 commit into from Dec 23, 2015

Conversation

geksilla
Copy link
Collaborator

ping @dvcrn, @spencerlyon2 to review.

@sglyon
Copy link
Contributor

sglyon commented Dec 22, 2015

@geksilla this is a great start. Good work!

I have a couple of comments:

  • SPC 0 goes to the tree view, but we can't use SPC # (for any number #) to get back out of it. This isn't particular to this PR, but just a reminder that we need access to proton-chain from non editor views.
  • I would love to add these numbers to each pane so users know exactly where they are going when then do SPC #. I was thinking that maybe we could just push a small number icon to the top right of the tab-bar on each pane? Or we could do it on the bottom of the gutter? These options aren't great because they can both be toggled, but maybe that's just something the user has to live with if he toggles everything off?
  • It would be great to have a single entry listed in the "prompt" area for [1-9] window N or something like that. Right now we have 10 of them for window 0 through 9 and it overflows that area.

[proton.lib.proton :as proton]))

(defn select-window-fn [n]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this to be its own function, or could we jsut use panes/focus-on-item in place of select-window-fn in the keybindings map?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:fx should be a function, so I wrap panes/focus-on-item into function that returns function + window number as argument.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't panes/focus-on-item a function though?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see it. Nevermind. Haha sorry for being slow here

@geksilla
Copy link
Collaborator Author

regarding first comment there is issue #40. I'll try to fix that in another PR.
Agree with label [0-9], added 10 labels for spacemacs consistency, also needs to revisit chain method to achieve this.

@dvcrn
Copy link
Owner

dvcrn commented Dec 23, 2015

Very cool PR! Can't wait to give this a shot. Is there anything you want to add? Otherwise I'll merge this now

@geksilla
Copy link
Collaborator Author

@dvcrn nothing to add for now. I would like to add single label [0-9] instead of 10, but it requires do some refactoring for keybindings and don't want to break things for now. I'll try in another PR if you don't mind.

dvcrn added a commit that referenced this pull request Dec 23, 2015
Added pane focus specific keybindings. refs #65
@dvcrn dvcrn merged commit 7b5c9e0 into dvcrn:master Dec 23, 2015
@dvcrn
Copy link
Owner

dvcrn commented Dec 23, 2015

👍

@geksilla geksilla deleted the feature/pane-focus-keybindings branch January 12, 2016 00:33
dvcrn added a commit that referenced this pull request Mar 22, 2016
Added pane focus specific keybindings. refs #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants