Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak search track to use QueueSong() #102

Closed
dvdmuckle opened this issue Oct 14, 2021 · 4 comments
Closed

Tweak search track to use QueueSong() #102

dvdmuckle opened this issue Oct 14, 2021 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@dvdmuckle
Copy link
Owner

For the spc search track command, after the initial searched for song is played, related songs generated by Spotify are added to the opts.URIs variable passed to PlayOpt(). While this works as expected, the side effect of this is the recommended tracks to be played are not visible in the Spotify app. Judging from the docs for the zmb3/Spotify library, this may be remedied by instead using QueueSong(), or specifically QueueSongOpt(), to queue up at least the recommended tracks after the initial play of the searched track. Also worth testing if queueing all the songs, the search result song and the recommended songs, works in the same manner as now.

@dvdmuckle dvdmuckle added hacktoberfest bug Something isn't working good first issue Good for newcomers labels Oct 14, 2021
@itslychee
Copy link

I think i have a working solution at https://github.com/ItsLychee/spc/tree/queue-tracks-fix, but I cannot be fully sure because I don't have Spotify Premium.

@dvdmuckle
Copy link
Owner Author

Nice! I can test it if you'd like to make a PR!

As an aside, that actually raises a good point about contributing to this project. I'll have to do some thinking on that.

@itslychee
Copy link

Will do! Thanks!

@dvdmuckle
Copy link
Owner Author

Turns out using QueueSongOpt() actually slows things down and doesn't appear to cause any UX changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants