More deterministic sorting, PHP5 and 7 were giving different results

src/OrientatedItem.php

@@ -90,6 +90,17 @@ public function getDepth()
         return $this->depth;
     }
 
+
+    /**
+     * Calculate the surface footprint of the current orientation
+     *
+     * @return int
+     */
+    public function getSurfaceFootprint()
+    {
+        return $this->width * $this->length;
+    }
+
     /**
      * Is this item stable (low centre of gravity), calculated as if the tipping point is >15 degrees.
      *

src/OrientatedItemFactory.php

@@ -86,8 +86,8 @@ public function getBestOrientation(
                         return 1;
                     }
                 }
-                // otherwise prefer leaving minimum possible gap
-                return min($orientationAWidthLeft, $orientationALengthLeft) - min($orientationBWidthLeft, $orientationBLengthLeft);
+                // otherwise prefer leaving minimum possible gap, or the greatest footprint
+                return $orientationAMinGap - $orientationBMinGap ?: $a->getSurfaceFootprint() - $b->getSurfaceFootprint();
             }
         });
 

tests/data/expected.csv

@@ -530,7 +530,7 @@
 1ce785fcfacad35c189a0d9d396eed90,1,0,40.4,1,0,40.4
 1cf82f87bb9c3dbb42af21c752cf84fc,1,0,30.9,1,0,30.9
 1d00692324341b13f9ec22e758270710,1,0,23,1,0,23
-1d07fe693017dde3ab6c7ef459de384f,1,0,40.2,1,0,40.2
+1d07fe693017dde3ab6c7ef459de384f,1,0,40.2,1,0,88.2
 1d161b401e3736e99ea949a29bd394c0,1,0,47.2,1,0,47.2
 1d1969e2f5f97c0cdfe027a41eac1526,3,70437.6,28.7,1,0,21.7
 1d397c99b8ad3fb440369aa5ae06fd34,1,0,30.9,1,0,30.9
@@ -545,7 +545,7 @@
 1df392d16403002997b44e622b40c25d,1,0,30.2,1,0,30.2
 1df7261c9a68c7aac4557b3ef1c92689,2,1764,56.7,2,1764,56.7
 1e2ea4827764957f2f0ebb6fc234b5a8,1,0,27.9,1,0,27.9
-1e3576b097febae61d71b70ae74c1c91,6,2099520,62.9,7,121916.6,24.8
+1e3576b097febae61d71b70ae74c1c91,6,2099520,62.9,6,845804.9,29.2
 1e52311b44caf51b40cfe59ecb1142f4,2,25760.3,24.7,2,25760.3,24.7
 1e541545aa9d21512203412de01518d6,1,0,33,1,0,33
 1e621fccb032a07c9aac966967279a8b,2,18090.3,35.7,2,18632.3,35.7
@@ -706,7 +706,7 @@
 2819f534da844e4a6940e78bbf5946ef,1,0,11.5,1,0,11.5
 28481fadd5a3c0f21c78e8a20327974a,3,28362.7,40.6,3,23154.7,40.6
 285364118fd21cfcea1d37612cc32110,1,0,16.4,1,0,16.4
-287a682fa23dfff23bf2e80e5705d294,3,8800.2,58.6,3,8800.2,58.6
+287a682fa23dfff23bf2e80e5705d294,3,8800.2,58.6,3,167204.2,58.6
 287b2ad13b0d20a7d111aef8474875f1,1,0,41.9,1,0,41.9
 28847b5a8cb6339b1947655b11be7f7c,1,0,32.1,1,0,32.1
 288a0908058eb783b73b536757f55c09,1,0,18.3,1,0,18.3
@@ -1129,7 +1129,7 @@
 414fe91e92f8ee2b9da5bd53947e8602,1,0,39.3,1,0,39.3
 4155b3e8153c79b68a5a0779be6c6f3c,1,0,41.2,1,0,41.2
 415f7f89525d77c17b95c6c838c18536,1,0,75.6,1,0,75.6
-4162ac2e41d7b5b8b916d6fb1e2beb2c,2,324,52.5,2,256,52.5
+4162ac2e41d7b5b8b916d6fb1e2beb2c,2,324,52.5,2,324,52.5
 416513bca3c8be3e8c7c25a32a8434d7,1,0,16.9,1,0,16.9
 4175dbdd2af48d4a8e517af0a69f2f3b,2,14762.3,23.8,2,12432.3,12.6
 417c520b1c5904699d21916bce7f68b6,1,0,41.8,1,0,41.8
@@ -1635,7 +1635,7 @@
 5e6a9ff015fe8f5f9421d7ecbed6ee45,2,427716,34.7,2,16,10.5
 5e70a7cf4baea6d6ece5fb124dcdbcd4,1,0,32.5,1,0,32.5
 5e7cde0c8600454d1a2672e2d744a577,1,0,34.4,1,0,34.4
-5e935a0874bd58024eee403b7f4b1763,2,30.3,28.2,2,56.3,14.8
+5e935a0874bd58024eee403b7f4b1763,2,30.3,28.2,1,0,17.1
 5e96581b32b70ca25bbb10a25c724c4f,1,0,30.8,1,0,30.8
 5e9e18221a395537a5dc85897f882636,1,0,51.2,1,0,51.2
 5eaae87bc205e4cad5f49b18b688ca5c,1,0,35.1,1,0,35.1
@@ -1709,7 +1709,7 @@
 62dcab5291143dc6fc110ed65e070627,2,2500,27.3,2,2500,27.3
 62e6b715a5a841db4292ce86055ad993,3,2646757.6,61,3,2646757.6,61
 62f1be6037444d4f1f37a941da288493,1,0,30.1,1,0,30.1
-62f9a1e4dc829da0729325702c2b031c,2,121,44.9,2,121,44.9
+62f9a1e4dc829da0729325702c2b031c,2,121,44.9,2,324,32.7
 62fd86f546a52d904692e1a9e919e089,1,0,12.5,1,0,12.5
 62fd8a5e4b91cd6c7cd1d0aebd05c4ca,1,0,40.9,1,0,40.9
 63102af3c3bc3f814be53dffddb29e2d,1,0,18.6,1,0,18.6
@@ -2008,7 +2008,7 @@
 73bb40c2188f99cde2e89bfe4af1c7f8,1,0,30.5,1,0,30.5
 73c213ea3057cc8090ad906c80ae7028,1,0,21.4,1,0,21.4
 73d4f329dfa2c62b41fb434ce4301cf5,2,9312.3,28.4,2,9312.3,28.4
-73d989d7186a1d3f71c7369ce5207762,2,1482.3,56.7,2,1482.3,56.7
+73d989d7186a1d3f71c7369ce5207762,2,1482.3,56.7,2,420.3,56.7
 740a3a71e6431c09a56237901d99d823,1,0,26,1,0,26
 742d8bf425f69c84e27c349d5623dcd8,2,16,28,1,0,17
 74422f12c555f9ef5575da01fef59dbc,1,0,50.7,1,0,50.7
@@ -2306,7 +2306,7 @@
 865c43072c811009f4da22ee0525dd8a,1,0,35.5,1,0,35.5
 86662df0ffaffef90bc3a5148f5e2de8,1,0,53.3,1,0,53.3
 8672f30b07050392198c25cf8ab568fd,2,6241,24.9,1,0,15.1
-867cd61bae65718bcc20e210c6b2234e,2,324,38.9,2,324,38.9
+867cd61bae65718bcc20e210c6b2234e,2,324,38.9,1,0,77.8
 867f7b009007b84c4f8882a07f9a4d55,2,20449,27.2,2,20449,27.2
 868c30a0d203e41ffa05cb3b1810bb7c,6,516.8,22,2,1206702.3,9.9
 869253e021bfbdfc79ffb385cf2678ec,2,1234321,16.5,1,0,19
@@ -2753,7 +2753,7 @@ a1a47ce91a9683caae00f42f61f8b908,1,0,39.3,1,0,39.3
 a1a857eba8fd4efa2d42128379294ea0,1,0,30.4,1,0,30.4
 a1bfb219268b4fc3cc0cba225b46da89,1,0,42,1,0,42
 a1dd11a2c0f6887207a34f1413dea3d1,1,0,50.7,1,0,50.7
-a1fa96f631f84b9de619bb6ecbc5b552,1,0,62,1,0,62
+a1fa96f631f84b9de619bb6ecbc5b552,1,0,62,1,0,28.3
 a24668cd188d0d8e177bc20aca9df0e0,1,0,35.5,1,0,35.5
 a25007d3ace81f5c2b1798ea9d4b20b7,1,0,45.9,1,0,45.9
 a2523b196b8b24b2b291da03b65d0e00,1,0,32.9,1,0,32.9
@@ -2790,7 +2790,7 @@ a3ce775d26ac8be3439ad24b24289f7e,2,87025,25.4,1,0,7.6
 a3dddf09e71c503bc692f33ed332e5d1,1,0,27.5,1,0,27.5
 a3e3c130372bee11d670de991210c9af,1,0,77.1,1,0,77.1
 a3f95b935375913e85f66e3cb6480a9d,1,0,48.5,1,0,48.5
-a403a7d8ed1e7ba344e9a814dc938960,2,1521,44.8,2,1521,44.8
+a403a7d8ed1e7ba344e9a814dc938960,2,1521,44.8,2,1521,32.6
 a413a12acaf8fc5b8cc5118d76c0ebce,1,0,36.5,1,0,36.5
 a4158880f12e267d4120f1c99e90b04b,1,0,5.8,1,0,5.8
 a41d7001551662ca358cf917b4fa71f5,1,0,46.3,1,0,46.3
@@ -2947,7 +2947,7 @@ aca7fdc10cb64ba59d49dbaf30db8d75,2,1609092.3,48.2,2,90.3,20.1
 acab98f452f8b8a262435c40beeda615,1,0,51.2,1,0,51.2
 acb9fe1568054c608c85846e324db053,2,11881,28.4,1,0,8.5
 acbb657b915f72ef780ac0230d777b4c,1,0,29.1,1,0,29.1
-acbeadee96d20b90baa7fe9cabcf0d87,1,0,61.8,1,0,61.8
+acbeadee96d20b90baa7fe9cabcf0d87,1,0,61.8,2,0.3,42.4
 acc21a7f8c9bc9ccb3061e43457b2996,2,804609,37.2,2,804609,37.2
 acc3d01c713b100321cc4d72067704f3,1,0,20.3,1,0,20.3
 acc43fb24a791224adf7bfe31b32ed44,1,0,23.3,1,0,23.3
@@ -3178,7 +3178,7 @@ badc912ed05a0e591cb51aaddbc32ad1,2,25440.3,15.8,1,0,9.5
 bae7822c468ba303cdb62a03ed3d6e8a,1,0,51.8,1,0,51.8
 baece3c7eda8103c1365f4abcc1e2757,2,139502.3,52.7,1,0,15.8
 baf7ebc276478e8bda1cb73749ce8ccc,1,0,37.7,1,0,37.7
-baf89d460bd1c0b7ce21d0fa83cf8da9,2,36864,41.8,2,36864,41.8
+baf89d460bd1c0b7ce21d0fa83cf8da9,2,36864,41.8,2,55696,41.8
 bb008fa7b181df68b8fd1f7d167a97a3,2,16641,30.6,2,16641,30.6
 bb25f0fc6cddc01991921d0d7db3f675,1,0,26.3,1,0,26.3
 bb376ebac2942e14373965b30876f33b,1,0,20.6,1,0,20.6
@@ -4199,7 +4199,7 @@ fa5d9ae6b63e9d33769081f7d4f2b115,1,0,30,1,0,30
 fa74eadd074843a8c78542d7602c31d4,1,0,48.4,1,0,48.4
 faa914e796a804997c19804300db0204,1,0,42.7,1,0,42.7
 faae756f0de0eef0384474255db1e662,1,0,41.6,1,0,41.6
-fac6c548649f983888821cb370e87966,1,0,34,1,0,34
+fac6c548649f983888821cb370e87966,1,0,34,1,0,74.5
 fad39d2e603bae2ac15387a3662de7ff,2,22201,37.6,1,0,11.3
 fae22f77df7666ed2fdc5757bd78ed07,1,0,33.9,1,0,33.9
 faec3db769a11d268cd4845fb3966167,1,0,41.1,1,0,41.1