Critical: Item not fit unrotated yet inserted #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an item doesn't fit unrotated it's inserted that direction since $fitsSameGap < $fitsRotatedGap. Fixed bug but did not update unit tests
|
Thanks for this - I'll try and take a look at the patch sometime in the next couple of days |
dvdoug
added a commit
that referenced
this pull request
Nov 19, 2014
Merge patch for issue #18 - in some cases, items that only fit in a single orientation were being recorded as fitting in the alternate, impossible one.
|
Thanks again for this - I've just tagged a new version that includes your patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an item doesn't fit unrotated it's inserted that direction since $fitsSameGap < $fitsRotatedGap. Creates an impossible scenario. Fixed bug but did not update unit tests.
Found bug using a box of 23x21x17 with an item of 16x23x10