Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Transformations give wrong longitudes when longitude is outside -90 to 90 degrees #5

Closed
caffme opened this issue Dec 19, 2015 · 3 comments

Comments

@caffme
Copy link
Contributor

caffme commented Dec 19, 2015

I have created failing tests for this in pull #4 I found the bug in a real transform but the test used transform parameters intended to make no change to the coordinates.

Some sample longitudes input => output:

-180 => 0
-100 => 80
-90 => -90
-80 => -80
0 => 0
80 => 80
90 => 90
100 => -80
180 => -0
@dvdoug
Copy link
Owner

dvdoug commented Dec 20, 2015

Hmm, thanks for this. The maths here is from the original code, so I guess I've got some light reading to do over xmas to try and figure out what's wrong here :/

@caffme
Copy link
Contributor Author

caffme commented Dec 21, 2015

Merry Christmas :)

I'd have fixed it if it was straight forward.

@dvdoug dvdoug closed this as completed in 07daecd Dec 31, 2015
@dvdoug
Copy link
Owner

dvdoug commented Dec 31, 2015

v1.1.2 includes the fix for this. Thanks for the bug report and the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants